Bump z2jh to v1.0 beta #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to be compatible with z2jh 1.0.0 with schema validation logic that will complain about unrecognized configuration options under singleuser or anything but `custom`.
5 tasks
consideRatio
approved these changes
May 31, 2021
There was a problem hiding this comment.
Thanks @yuvipanda this LGTM!
I saw that you have pushed the k8s-hub replacement image as well. Merge?
damianavila
reviewed
Jun 1, 2021
damianavila
reviewed
Jun 1, 2021
damianavila
approved these changes
Jun 1, 2021
|
Thanks, @damianavila! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
singleuser.admintocustom.singleuserAdminto satisfy the helmJSON schema, which doesn't allow extra properties under
singleuserrequirements.yamlfile intoChart.yamlfiles - with helm3 thesedo not need to be together
Splitting up code from #429 that
works on just upgrading code to z2jh 1.0-beta1
Fixes #414